OnPair

Sample report

What OnPair tells you about a pull request.

This is the report you get on every pull request, in your dashboard and as a GitHub check. Read it before you pay for anything.

An illustrative pull request on a sample repository. A report from a real open-source project replaces it soon.

acme/billing-api #482

1 blocking, 1 warning

Nest retry settings under retry and add MAIL_TRANSPORT

9f3c2a123 September 20266 doc files readgpt-5-mini

Summary

This pull request renames the retryLimit setting to retry.limit and introduces a required MAIL_TRANSPORT variable. The configuration reference and the setup guide still describe the old behaviour.

  1. Environment variable

    blockinghigh confidence

    MAIL_TRANSPORT is now required at boot, but neither the setup section of README.md nor .env.example mentions it. A fresh checkout will fail to start.

    Changed code
    start/env.tsconfig/mail.ts
    Docs that disagree
    README.md.env.example

    Suggested fix

    Add MAIL_TRANSPORT=json to .env.example and a line to the README setup steps: "Set MAIL_TRANSPORT to smtp to send real email; json logs messages instead."

  2. Configuration key

    warningmedium confidence

    retryLimit moved to retry.limit. docs/configuration.md:41 still tells readers to set retryLimit, which is now ignored.

    Changed code
    app/config/billing.ts
    Docs that disagree
    docs/configuration.md

    Suggested fix

    Replace "Set retryLimit to control how many times a failed charge is retried" with "Set retry.limit to control how many times a failed charge is retried."

Get this on your next pull request.

Start checking pull requestsSee pricing

14-day money-back guarantee · cancel in one click